Added new 'jerry_value_instanceof' API function. #2723
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaszloLango
added
api
galpeter
reviewed
Jan 22, 2019
|
|
||
| **Summary** | ||
|
|
||
| Returns whether the given `jerry_value_t` is an instance of the given prototype. |
There was a problem hiding this comment.
Isn't there any difference between the es5.1 vs es2015 instanceof internal workings? Could that affect the api workings?
There was a problem hiding this comment.
It should not affect the api workings, but may affect the internal workings (e.g.: instance of classes).
There was a problem hiding this comment.
Classes are simple functions, the only specializations they have is a bytecode status flag, so I think it couldn't have any affect on it.
rerobika
reviewed
Jan 22, 2019
LaszloLango
force-pushed
the
add-instanceof-api
branch
from
48a1077 to
6e31e64
Compare
galpeter
reviewed
Jan 23, 2019
akosthekiss
reviewed
Jan 27, 2019
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]
LaszloLango
force-pushed
the
add-instanceof-api
branch
from
6e31e64 to
c1bddc7
Compare
|
Closing PR to prevent merging. Let's discuss and make decision on #2746 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: László Langó [email protected]